Messages in this thread | | | Date | Tue, 4 Feb 2014 23:22:11 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 4/6] regulator: add bcm59056 regulator driver |
| |
On Tue, Feb 04, 2014 at 04:29:14PM -0500, Matt Porter wrote: > On Tue, Feb 04, 2014 at 05:28:36PM +0000, Mark Brown wrote:
> > > + /* > > > + * Regulator API handles empty constraints but not NULL > > > + * constraints > > > + */ > > > + if (!reg_data) > > > + continue;
> > It should do... if not then make it so since that'd mean most drivers > > are buggy.
> Ahh, I see there is a check for NULL in the core. Will drop.
It was missing in some older kernels (much older now IIRC) - it's possible that comment was written before this got fixed. [unhandled content-type:application/pgp-signature] | |