Messages in this thread | | | Date | Tue, 4 Feb 2014 18:43:27 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: gpio: bugfix: add gpios-status for DT |
| |
On Thu, Jan 30, 2014 at 09:25:14PM -0800, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > config->gpios[x].flags indicates initial pin status, > and it will be used for drvdata->state > on gpio_regulator_probe().
I've applied this, thanks. However, a couple of things that it'd be nice to improve with followup patches:
> +- gpios-states : gpios pin's initial states. 1 means HIGH
A mention that this is an array of values would be good (it's clear from the code but not from the document), as would saying that the defualt is low if nothing is specified.
> + if (proplen != config->nr_gpios) { > + /* gpios <-> gpios-states mismatch */ > + prop = NULL; > + } > + }
It's probably worth printing a warning here. [unhandled content-type:application/pgp-signature] | |