Messages in this thread | | | From | Andy Lutomirski <> | Date | Tue, 4 Feb 2014 10:14:54 -0800 | Subject | Re: [PATCH v11 1/9] Make vsyscall_gtod_data handling x86 generic |
| |
On Tue, Feb 4, 2014 at 2:15 AM, <stefani@seibold.net> wrote: > From: Stefani Seibold <stefani@seibold.net> > > This patch move the vsyscall_gtod_data handling out of vsyscall_64.c > into an additonal file vsyscall_gtod.c to make the functionality > available for x86 32 bit kernel. > > It also adds a new vsyscall_32.c which setup the VVAR page.
Other than the unconditional __set_fixmap calls, I think this is okay.
(Can you *please* directly answer review comments rather than just sending out new versions at high speed. The current approach means that I need to reread the patch again every time to see how you've responded, and I'm currently disinclined to believe that a new version will actually address a review comment *at all*.)
--Andy
| |