lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] ASoC: tda998x: adjust the audio CTS_N pre-divider from audio format
On Thu, Jan 30, 2014 at 12:08:06PM +0100, Jean-Francois Moine wrote:

> - if (format == p->audio_format) {
> + if (format == p->audio_format &&
> + params_format(params) == priv->audio_sample_format) {
> reg_write(priv, REG_ENA_AP, p->audio_cfg);
> return;

I find the above confusing and probably deserving of a comment
explaining the logic. I think it's trying to skip noop configuration
updates?

> }
> p->audio_format = format;
> + priv->audio_sample_format = params_format(params);

You should be using params_width() for the number of bits per sample.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-04 20:01    [W:0.105 / U:1.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site