Messages in this thread | | | Date | Tue, 4 Feb 2014 11:21:10 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: bcm: fix pointer-integer size mismatch warnings |
| |
On Tue, Feb 04, 2014 at 03:59:23PM +0900, SeongJae Park wrote: > Fix the pointer-integer size mismatch warnings below: > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: > drivers/staging/bcm/CmHost.c:1387:39: warning: cast to pointer from > integer of different size [-Wint-to-pointer-cast] > pstAddIndication->psfAuthorizedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAuthorizedSet); > ^ > drivers/staging/bcm/CmHost.c:1426:37: warning: cast to pointer from > integer of different size [-Wint-to-pointer-cast] > pstAddIndication->psfAdmittedSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfAdmittedSet); > ^ > drivers/staging/bcm/CmHost.c:1440:35: warning: cast to pointer from > integer of different size [-Wint-to-pointer-cast] > pstAddIndication->psfActiveSet = (struct bcm_connect_mgr_params *)ntohl((ULONG)pstAddIndication->psfActiveSet); > ^
No. You haven't fixed the bug, you've just silenced the warning so now someone has to spent hours and hours looking for it when it comes time to write a proper fix. Don't do that.
regards, dan carpenter
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |