Messages in this thread | | | Date | Tue, 4 Feb 2014 18:54:52 +0200 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH v4 1/3] clocksource: timer-keystone: introduce clocksource driver for Keystone |
| |
It was so in v1. But it was decided to use explicit memory barriers, because we're always sure the memory barriers are there and that they're properly documented. Also in this case I don't need to add keystone readl/writel relaxed function variants and to use mixed calls of writel/writel_relaxed functions.
See: http://www.spinics.net/lists/arm-kernel/msg294941.html
On 02/04/2014 06:24 PM, Thomas Gleixner wrote: > On Tue, 4 Feb 2014, Ivan Khoronzhuk wrote: >> + keystone_timer_writel(off, TCR); >> + /* here we have to be sure the timer has been disabled */ >> + wmb(); > We have explicit writew_relaxed and writew. Why open coding the > barriers? > > Thanks, > > tglx
-- Regards, Ivan Khoronzhuk
| |