Messages in this thread | | | Date | Tue, 4 Feb 2014 11:05:31 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: core: Make regulator object reflect configured voltage |
| |
On Mon, Feb 03, 2014 at 09:54:28PM -0800, Bjorn Andersson wrote:
> + /* > + * Make the regulator reflect the configured voltage selected in > + * machine_constraints_voltage() > + */ > + if (rdev->constraints->apply_uV && > + rdev->constraints->min_uV == rdev->constraints->max_uV) { > + regulator->min_uV = rdev->constraints->min_uV; > + regulator->max_uV = rdev->constraints->min_uV; > + } > +
Why not do this at the time we apply the voltage? That would seem to be more robust, doing it in a separate place means that we might update one bit of code and not the other or might change the execution path so that one gets run and the other doesn't. [unhandled content-type:application/pgp-signature] | |