lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 043/133] iwlwifi: mvm: fix missing cleanup in .start() error path
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eliad Peller <eliadx.peller@intel.com>

    commit 91b0d1198417cf4fd9a7bd4138b6909f0b359099 upstream.

    Cleanup of iwl_mvm_leds was missing in case of error,
    resulting in the following warning:

    WARNING: at lib/kobject.c:196 kobject_add_internal+0x1f4/0x210()
    kobject_add_internal failed for phy0-led with -EEXIST, don't try to register things with the same name in the same directory.

    which prevents further reloads of the driver.

    Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
    Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/iwlwifi/mvm/ops.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/iwlwifi/mvm/ops.c
    +++ b/drivers/net/wireless/iwlwifi/mvm/ops.c
    @@ -446,6 +446,7 @@ iwl_op_mode_mvm_start(struct iwl_trans *

    out_unregister:
    ieee80211_unregister_hw(mvm->hw);
    + iwl_mvm_leds_exit(mvm);
    out_free:
    iwl_phy_db_free(mvm->phy_db);
    kfree(mvm->scan_cmd);



    \
     
     \ /
      Last update: 2014-02-05 16:01    [W:4.093 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site