lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 076/104] ieee802154: Fix memory leak in ieee802154_add_iface()
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christian Engelmayer <cengelma@gmx.at>

    [ Upstream commit 267d29a69c6af39445f36102a832b25ed483f299 ]

    Fix a memory leak in the ieee802154_add_iface() error handling path.
    Detected by Coverity: CID 710490.

    Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ieee802154/nl-phy.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/net/ieee802154/nl-phy.c
    +++ b/net/ieee802154/nl-phy.c
    @@ -224,8 +224,10 @@ static int ieee802154_add_iface(struct s

    if (info->attrs[IEEE802154_ATTR_DEV_TYPE]) {
    type = nla_get_u8(info->attrs[IEEE802154_ATTR_DEV_TYPE]);
    - if (type >= __IEEE802154_DEV_MAX)
    - return -EINVAL;
    + if (type >= __IEEE802154_DEV_MAX) {
    + rc = -EINVAL;
    + goto nla_put_failure;
    + }
    }

    dev = phy->add_iface(phy, devname, type);



    \
     
     \ /
      Last update: 2014-02-05 09:21    [W:4.681 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site