Messages in this thread | | | Date | Tue, 04 Feb 2014 10:25:44 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] kernel/kprobes.c: move cleanup_rp_inst() to where CONFIG_KRETPROBES enabled |
| |
On 02/03/2014 11:42 PM, Masami Hiramatsu wrote: > (2014/02/03 20:48), Chen Gang wrote: >> On 02/02/2014 10:40 AM, Masami Hiramatsu wrote: >>> (2014/02/01 21:17), Chen Gang wrote: >>>> When CONFIG_KRETPROBES disabled, cleanup_rp_inst() is useless too. It >>>> is only called by unregister_kretprobes() which is in CONFIG_KRETPROBES >>>> enabled area. >>>> >>>> The related warning (allmodconfig under avr32): >>>> >>>> kernel/kprobes.c:1181: warning: 'cleanup_rp_inst' defined but not used >>> >>> This patch itself looks good to me. >>> And it seems that not only the cleanup_rp_inst, but also other >>> kretprobe related functions should be moved (free_rp_inst,etc) >>> >> >> OK, thanks, need/should I check them again and send patch v2 for them? > > Yes, I'm happy to review it :) > > Thank you! >
I will/should finish in these days (within 2014-02-07).
Thanks. -- Chen Gang
Open, share and attitude like air, water and life which God blessed
| |