Messages in this thread | | | Date | Mon, 3 Feb 2014 22:34:40 +0000 | Subject | Re: [PATCH] arm64: Add architecture support for PCI | From | Andrew Murray <> |
| |
On 3 February 2014 18:43, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index 4cc813e..ce5bad2 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -120,9 +120,13 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) > /* > * I/O port access primitives. > */ > +#define arch_has_dev_port() (0) > #define IO_SPACE_LIMIT 0xffff > #define PCI_IOBASE ((void __iomem *)(MODULES_VADDR - SZ_2M)) > > +#define ioport_map(port, nr) (PCI_IOBASE + ((port) & IO_SPACE_LIMIT)) > +#define ioport_unmap(addr)
I'm not sure that this will work. The in[bwl], out[bwl] macros in arch/arm64/include/asm/io.h already add the PCI_IOBASE offset.
Instead of these two #defines, why not just enforce that GENERIC_PCI_IOMAP is enabled? Or at least wrap these defines with 'if (!config_enabled(CONFIG_GENERIC_PCI_IOMAP))' or similar.
> + > static inline u8 inb(unsigned long addr) > { > return readb(addr + PCI_IOBASE);
Andrew Murray
| |