lkml.org 
[lkml]   [2014]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image
On Mon, Feb 03, 2014 at 02:13:27PM -0500, Boris Ostrovsky wrote:
> I thought that it may be sufficient to check for !container in
> save_microcode_in_initrd_amd() before performing relocation. If the
> signature was wrong, we would have found out about it in
> load_ucode_bsp() -> apply_ucode_in_initrd() and returned right away,

Your original test case which exploded had exactly that scenario - it
was pointing to Intel ucode so container wasn't NULL. Thus we need to
check the sig in find_ucode_in_initrd().

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-02-03 21:21    [W:0.370 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site