Messages in this thread | | | Date | Mon, 3 Feb 2014 20:30:00 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image |
| |
On Mon, Feb 03, 2014 at 02:13:27PM -0500, Boris Ostrovsky wrote: > I thought that it may be sufficient to check for !container in > save_microcode_in_initrd_amd() before performing relocation. If the > signature was wrong, we would have found out about it in > load_ucode_bsp() -> apply_ucode_in_initrd() and returned right away,
Your original test case which exploded had exactly that scenario - it was pointing to Intel ucode so container wasn't NULL. Thus we need to check the sig in find_ucode_in_initrd().
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |