Messages in this thread | | | Date | Mon, 3 Feb 2014 11:52:08 +0530 | Subject | Re: [PATCH] acpi-cpufreq: De-register cpu notifier and free struct msr on error. | From | Viresh Kumar <> |
| |
On 28 January 2014 09:28, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > If cpufreq_register_driver() fails we would free the acpi driver > related structures but not free the ones allocated > by acpi_cpufreq_boost_init() function. This meant that as > the driver error-ed out and a CPU online/offline event came > we would crash and burn as one of the CPU notifiers would point > to garbage. > > This fixes a regression that commit cfc9c8ed03e4d908f2388af8815f44c87b503aaf > "acpi-cpufreq: Adjust the code to use the common boost attribute" > introduced. > > CC: Lukasz Majewski <l.majewski@samsung.com> > CC: Myungjoo Ham <myungjoo.ham@samsung.com> > CC: Viresh Kumar <viresh.kumar@linaro.org> > CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > CC: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > drivers/cpufreq/acpi-cpufreq.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
| |