lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso
From
Date
Am Donnerstag, den 27.02.2014, 16:18 -0800 schrieb Andy Lutomirski:
> I'd still like someone else to confirm that the 32-bit vDSO is working
> on all common configurations before I'm happy with it, but this should
> be a considerable improvement.
>
> Someone who maintains the clock code should review the changes in:
>
> commit 0fc8a237cbe98a06962f5ea37d24fc2369e23c74
> Author: Stefani Seibold <stefani@seibold.net>
> Date: Wed Feb 19 10:09:10 2014 +0100
>
> x86, vdso: Add 32-bit VDSO time support for the 64-bit kernel
>
> very carefully.
>
> There's still something extremely questionable about VDSO_PAGES in the
> 32-bit vDSO code. It appears to be terminally screwed up, and AFAICS it
> only works at all because none of the 32-bit vDSO images ever exceed
> 4096 bytes.
>

The 4096 bytes limit was not introduced by the patch set. It is still
there for compatibility reason.

> Note: Patch 4 fixes a bug that's present even in -linus, so it might
> make sense to send it to Linus more quickly than the rest of this
> series.
>
> Changes from v1:
> - Adjust CFLAGS instead of using asmlinkage.
> - Add more fixes.
>
> Andy Lutomirski (4):
> x86: Use the default ABI for the 32-bit vDSO
> x86: Inline the CLOCK_MONOTONIC vdso code
> x86: Patch alternatives in the 32-bit vDSO
> x86: Zero-pad the VVAR page
>
> arch/x86/include/asm/vdso.h | 2 ++
> arch/x86/kernel/vmlinux.lds.S | 5 +++++
> arch/x86/vdso/Makefile | 2 +-
> arch/x86/vdso/vclock_gettime.c | 2 +-
> arch/x86/vdso/vdso32-setup.c | 25 +++++++++++++------------
> arch/x86/vdso/vma.c | 9 ++++++---
> 6 files changed, 28 insertions(+), 17 deletions(-)
>




\
 
 \ /
  Last update: 2014-02-28 10:01    [W:0.231 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site