lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] lockdep: increase static allocations
    From
    Date
    On Fri, 2014-02-28 at 14:32 -0500, Sasha Levin wrote: 
    > On 01/08/2014 02:21 PM, Sasha Levin wrote:
    > > Fuzzing a recent kernel with a large configuration hits the static
    > > allocation limits and disables lockdep.
    > >
    > > This patch doubles the limits.
    > >
    > > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
    > > ---
    > > kernel/locking/lockdep_internals.h | 6 +++---
    > > 1 file changed, 3 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/kernel/locking/lockdep_internals.h b/kernel/locking/lockdep_internals.h
    > > index 4f560cf..51c4b24 100644
    > > --- a/kernel/locking/lockdep_internals.h
    > > +++ b/kernel/locking/lockdep_internals.h
    > > @@ -54,9 +54,9 @@ enum {
    > > * table (if it's not there yet), and we check it for lock order
    > > * conflicts and deadlocks.
    > > */
    > > -#define MAX_LOCKDEP_ENTRIES 16384UL
    > > +#define MAX_LOCKDEP_ENTRIES 32768UL
    > >
    > > -#define MAX_LOCKDEP_CHAINS_BITS 15
    > > +#define MAX_LOCKDEP_CHAINS_BITS 16
    > > #define MAX_LOCKDEP_CHAINS (1UL << MAX_LOCKDEP_CHAINS_BITS)
    > >
    > > #define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
    > > @@ -65,7 +65,7 @@ enum {
    > > * Stack-trace: tightly packed array of stack backtrace
    > > * addresses. Protected by the hash_lock.
    > > */
    > > -#define MAX_STACK_TRACE_ENTRIES 262144UL
    > > +#define MAX_STACK_TRACE_ENTRIES 524288UL
    > >
    > > extern struct list_head all_lock_classes;
    > > extern struct lock_chain lock_chains[];
    > >
    >
    >
    > Can someone pick the patch up please? PeterZ even (seemed to) acked it.

    I have to do the (exact) same to rt trees, else lockdep routinely gets
    in a snit, takes it's cool toys and goes home.

    -Mike



    \
     
     \ /
      Last update: 2014-03-01 06:21    [W:5.800 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site