[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/4] HID: ll transport cleanup: final round
Hi guys,

by shuffling around the hid files, I noticed that I introduced a regression
in commit 3a75b24949a8 (HID: hidraw: replace hid_output_raw_report() calls...).
We removed the hid_output_raw_report() calls in hidraw, which means that
the special sixasis handling was broken from the hidraw callers (I don't know
if there are any however).

So I took some time to finish this work. I am not particularly proud of patches
2/4 and 3/4:

For the patch 2/4, we need to get some feedbacks from David Barksdale,
because the spec seems a little bit nebulous to me and I'd prefer having real
tests to confirm that it is the right choice. I hope that David B. will send
his feedbacks soon. If not, I still would like to see this in 3.15 with the
rest of the cleanup to avoid having new drivers which use the old API.

Regarding 3/4, well, I added 2 quirks which are not so trivials, but I am not
sure I could do something else.

Anyway, happy reviewing.


Benjamin Tissoires (4):
HID: cp2112: remove various hid_out_raw_report calls
HID: cp2112: remove the last hid_output_raw_report() call
HID: sony: do not rely on hid_out_raw_report
HID: remove hid_output_raw_report transport implementations

drivers/hid/hid-cp2112.c | 28 +++++++++++++++-----
drivers/hid/hid-sony.c | 59 ++++++++++---------------------------------
drivers/hid/hidraw.c | 3 ++-
drivers/hid/i2c-hid/i2c-hid.c | 14 ----------
drivers/hid/uhid.c | 1 -
drivers/hid/usbhid/hid-core.c | 19 +++++---------
include/linux/hid.h | 21 ++-------------
net/bluetooth/hidp/core.c | 14 ----------
8 files changed, 45 insertions(+), 114 deletions(-)


 \ /
  Last update: 2014-03-01 02:01    [W:1.571 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site