[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: smp_call_function_single with wait=0 considered harmful
On 02/28/2014 07:39 AM, Peter Zijlstra wrote:

> Subject: stop_machine: Fix^2 race between stop_two_cpus() and stop_cpus()
> We must use smp_call_function_single(.wait=1) for the
> irq_cpu_stop_queue_work() to ensure the queueing is actually done under
> stop_cpus_lock. Without this we could have dropped the lock by the time
> we do the queueing and get the race we tried to fix.
> Fixes: 7053ea1a34fa ("stop_machine: Fix race between stop_two_cpus() and stop_cpus()")
> Cc: Prarit Bhargava <>
> Cc: Rik van Riel <>
> Cc: Mel Gorman <>
> Signed-off-by: Peter Zijlstra <>

Reviewed-by: Rik van Riel <>

All rights reversed

 \ /
  Last update: 2014-02-28 18:41    [W:0.053 / U:7.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site