lkml.org 
[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] hwrng: atmel - Use devm_clk_get()
On 27/02/2014 06:00, Jingoo Han :
> Use devm_clk_get() to make cleanup paths simpler.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Thanks a lot.

> ---
> drivers/char/hw_random/atmel-rng.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
> index dfeddf2..851bc7e 100644
> --- a/drivers/char/hw_random/atmel-rng.c
> +++ b/drivers/char/hw_random/atmel-rng.c
> @@ -63,13 +63,13 @@ static int atmel_trng_probe(struct platform_device *pdev)
> if (IS_ERR(trng->base))
> return PTR_ERR(trng->base);
>
> - trng->clk = clk_get(&pdev->dev, NULL);
> + trng->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(trng->clk))
> return PTR_ERR(trng->clk);
>
> ret = clk_enable(trng->clk);
> if (ret)
> - goto err_enable;
> + return ret;
>
> writel(TRNG_KEY | 1, trng->base + TRNG_CR);
> trng->rng.name = pdev->name;
> @@ -85,9 +85,6 @@ static int atmel_trng_probe(struct platform_device *pdev)
>
> err_register:
> clk_disable(trng->clk);
> -err_enable:
> - clk_put(trng->clk);
> -
> return ret;
> }
>
> @@ -99,7 +96,6 @@ static int atmel_trng_remove(struct platform_device *pdev)
>
> writel(TRNG_KEY, trng->base + TRNG_CR);
> clk_disable(trng->clk);
> - clk_put(trng->clk);
>
> return 0;
> }
>


--
Nicolas Ferre


\
 
 \ /
  Last update: 2014-02-28 16:01    [W:0.083 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site