[lkml]   [2014]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net RESEND] vlan: don't allow to add VLAN on VLAN device
On 2014/2/28 11:45, John Fastabend wrote:
> On 2/27/2014 6:43 PM, Ding Tianhong wrote:
>> I run these steps:
>> modprobe 8021q
>> vconfig add eth2 20
>> vconfig add eth2.20 20
>> ifconfig eth2 xx.xx.xx.xx
>> then the Call Trace happened:
> [...]
>> ========================================================================
>> The reason is that if add vlan on vlan dev, the vlan dev will create vlan_info,
>> then the notification will let the real dev to run dev_set_rx_mode() and hold
>> netif_addr_lock, and then the real dev will call ndo_set_rx_mode(), if the real
>> dev is vlan dev, the ndo_set_rx_mode() will hold netif_addr_lock again, so deadlock
>> happened.
>> Don't allow to add vlan on vlan dev to fix this problem.
>> Signed-off-by: Ding Tianhong <>
>> ---
> I'm not sure we can just disable stacked vlans. There might be something
> using them today and they have worked in the past. Lets try to find a
> better fix.
> .John

Yes, maybe I miss something, can you gave me a scene that the use of eth2.20.30?
the device is created from vlan device eth2.20, than I will find a better way to fix it.


> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to
> More majordomo info at
> Please read the FAQ at

 \ /
  Last update: 2014-02-28 07:22    [W:0.242 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site