Messages in this thread | | | Date | Thu, 27 Feb 2014 10:22:27 -0600 | From | Aravind Gopalakrishnan <> | Subject | Re: [PATCH] amd64_edac: Add support for newer F16h models |
| |
On 2/24/2014 8:09 AM, Borislav Petkov wrote: > On Fri, Feb 21, 2014 at 03:04:47PM -0600, Aravind Gopalakrishnan wrote: >> F{3,4} are used by hwmon/k10temp.c and hwmon/fam15h_power.c and they >> will need definitions to be places here in pci_ids.h But I'm not sure >> if the hwmon drivers need to carry support for this model yet (will >> verify that) >> >> If not, I'll remove them and resend. > Yes, please check that and let me know. > > Ok, here's more info: we will need to add support in k10temp for this model; and support is not required in fam15h_power as register bits used by the driver code are unavailable for OS. But F{3,4} usage is split: k10temp uses F3 device ID and fam15h_power uses F4 device ID.
Not sure if you want to split these definitions between amd_nb.h and pci_ids.h or just let it be.
Thanks, -Aravind.
| |