lkml.org 
[lkml]   [2014]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver
On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote:
> > + /* read revision and configuration information */
> > + val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK;
> > +
>
> The ees shit is not zero and you got wrong ee. Could you add the line
> below or something similar:
>
> val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK;
>

Good catch. I missed the shift when I reworked and got lucky that the revision
is in the lower 8 bits and is non-zero.

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation


\
 
 \ /
  Last update: 2014-02-27 06:44    [W:0.094 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site