Messages in this thread | | | Subject | Re: The sheer number of sparse warnings in the kernel | From | Joe Perches <> | Date | Wed, 26 Feb 2014 17:06:39 -0800 |
| |
On Wed, 2014-02-26 at 16:51 -0800, H. Peter Anvin wrote: > On 02/26/2014 04:48 PM, Joe Perches wrote: > > err.h could also return bool instead of long for the > > IS_ERR and IS_ERR_OR_NULL tests. > > This is definitely true... although we should check that that doesn't > make the code worse as this is used *all over* the kernel.
I tested using arch/x86/crypto/ x86-64 and 32 and there are no .o file differences using bool or long via objdump -d new and old
> > Maybe something like this could be useful. > > > > Shut up the unsigned<->signed pointer conversions > > and implicit conversions in the Makefile. > > Sounds like two separate patches to me.
Yeah, it was just for discussion.
I think gcc 4.8 is overly noisy about those 2.
| |