Messages in this thread | | | Date | Wed, 26 Feb 2014 15:07:14 -0800 | From | Kent Overstreet <> | Subject | Re: [PATCH RESEND 3/3] percpu_ida: Sanity check initialization parameters |
| |
On Thu, Feb 06, 2014 at 01:24:55PM +0100, Alexander Gordeev wrote: > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Kent Overstreet <kmo@daterainc.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org> > --- > lib/percpu_ida.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/lib/percpu_ida.c b/lib/percpu_ida.c > index c2fa3dc..81b5ae9 100644 > --- a/lib/percpu_ida.c > +++ b/lib/percpu_ida.c > @@ -305,6 +305,11 @@ int __percpu_ida_init(struct percpu_ida *pool, unsigned long nr_tags, > { > unsigned i, cpu, order; > > + if (batch_size > max_size) > + return -ERANGE; > + if (!batch_size) > + return -EINVAL; > + > memset(pool, 0, sizeof(*pool)); > > init_waitqueue_head(&pool->wait);
Acked-by: Kent Overstreet <koverstreet@daterainc.com>
| |