Messages in this thread | | | Date | Wed, 26 Feb 2014 20:11:40 +0900 | Subject | Re: [PATCH] staging: lustre: make functions as static | From | DaeSeok Youn <> |
| |
Actually , I saw some code like this file which is seperate line between return value and function name. So I didn't make one line of them.
Ok, I will make another patch after merge this one. Thanks. Daeseok Youn.
2014-02-26 18:20 GMT+09:00, Dan Carpenter <dan.carpenter@oracle.com>: > On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote: >> >> These functions are only referenced in this file scope >> so it can be marked static. >> And remove space between function name and open parenthesis. > > If it's on the same line as a "static" change then it's fine, otherwise > it should go in a separate patch. > > regards, > dan carpenter > >
| |