Messages in this thread | | | Date | Tue, 25 Feb 2014 17:05:34 -0800 (PST) | From | Hugh Dickins <> | Subject | Re: [PATCH] ksm: Expose configuration via sysctl |
| |
On Tue, 25 Feb 2014, Johannes Weiner wrote: > On Tue, Feb 25, 2014 at 12:28:04AM +0100, Alexander Graf wrote: > > Configuration of tunables and Linux virtual memory settings has traditionally > > happened via sysctl. Thanks to that there are well established ways to make > > sysctl configuration bits persistent (sysctl.conf). > > > > KSM introduced a sysfs based configuration path which is not covered by user > > space persistent configuration frameworks. > > > > In order to make life easy for sysadmins, this patch adds all access to all > > KSM tunables via sysctl as well. That way sysctl.conf works for KSM as well, > > giving us a streamlined way to make KSM configuration persistent. > > ksm can be a module, so this won't work.
That's news to me. Are you writing of some Red Hat patches, or just misled by the "module_init(ksm_init)" which used the last line of ksm.c?
I don't mind Alex's patch, but I do think the same should be done for THP as for KSM, and a general solution more attractive than more #ifdefs one by one. Should a general solution just be in userspace, in sysctl(8)?
Hugh
| |