Messages in this thread | | | Date | Wed, 26 Feb 2014 09:12:27 +0800 | From | Li Zefan <> | Subject | Re: [PATCH v3] sysfs: fix namespace refcnt leak |
| |
On 2014/2/25 23:17, Tejun Heo wrote: > On Tue, Feb 25, 2014 at 07:19:55AM -0800, Greg Kroah-Hartman wrote: >> On Tue, Feb 25, 2014 at 09:42:56AM -0500, Tejun Heo wrote: >>> On Tue, Feb 25, 2014 at 07:28:44PM +0800, Li Zefan wrote: >>>> As mount() and kill_sb() is not a one-to-one match, we shoudn't get >>>> ns refcnt unconditionally in sysfs_mount(), and instead we should >>>> get the refcnt only when kernfs_mount() allocated a new superblock. >>>> >>>> v2: >>>> - Changed the name of the new argument, suggested by Tejun. >>>> - Made the argument optional, suggested by Tejun. >>>> >>>> v3: >>>> - Make the new argument as second-to-last arg, suggested by Tejun. >>>> >>>> Reviewed-by: Tejun Heo <tj@kernel.org> >>>> Signed-off-by: Li Zefan <lizefan@huawei.com> >>> >>> Acked-by: Tejun Heo <tj@kernel.org> >> >> Is this needed for 3.14-final or 3.15? > > It also fixes sysfs refcnting, so should also be applied to 3.14, I > think. >
Actually it fixes sysfs refcnting only, but the change to kernfs is necessary for fixing cgroupfs.
| |