Messages in this thread | | | Date | Tue, 25 Feb 2014 22:47:48 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 06/11] kexec: A new system call, kexec_file_load, for in kernel kexec |
| |
On Tue, Feb 25, 2014 at 08:35:19PM +0100, Petr Tesarik wrote: > #define BIT(nr) (1UL << (nr)) > > For my part I'm not convinced it's a better way to do it, unless > Borislav also wanted to suggest adding an enum for the bit number > values...
Well,
#define KEXEC_FILE_UNLOAD BIT(1)
is much more readable.
The enum thing is also nice to have but it's not my personal preference.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |