Messages in this thread |  | | Subject | Re: [PATCH 1/8] security: Use a more current logging style | From | Joe Perches <> | Date | Tue, 25 Feb 2014 11:34:12 -0800 |
| |
On Tue, 2014-02-25 at 13:10 -0600, Serge Hallyn wrote: > Quoting Joe Perches (joe@perches.com): > > Convert printks to pr_<level>. [] > Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com> > > Though should warn_setuid_and_fcaps_mixed be using > pr_info_once()?
Yup, thanks. I'll send a follow-on with your reported-by if/after this is applied and I'll send a V2 now so James could apply that instead if that's what he prefers.
> > diff --git a/security/commoncap.c b/security/commoncap.c [] > > @@ -46,9 +48,8 @@ static void warn_setuid_and_fcaps_mixed(const char *fname) > > { > > static int warned; > > if (!warned) { > > - printk(KERN_INFO "warning: `%s' has both setuid-root and" > > - " effective capabilities. Therefore not raising all" > > - " capabilities.\n", fname); > > + pr_info("warning: `%s' has both setuid-root and effective capabilities, therefore not raising all capabilities\n", > > + fname);
pr_info_once(etc...
> > warned = 1; > > } > > }
|  |