Messages in this thread | | | Date | Tue, 25 Feb 2014 12:56:07 +0100 | From | Peter Zijlstra <> | Subject | Re: [RFC patch 1/5] hrtimer: Always check for HRTIMER_MODE_REL |
| |
On Fri, Feb 21, 2014 at 05:56:15PM -0000, Thomas Gleixner wrote: > We have not just HRTIMER_MODE_REL and HRTIMER_MODE_ABS, so a direct > check for mode == HRTIMER_MODE_ABS is not sufficient. > > Always check for the HRTIMER_MODE_REL bit.
This seems to come from having changed hrtimer_mode from a value field to a bit field with the addition of PINNED.
But yeah; this certainly fixes these two sites. Ideally we'd to something better to avoid making the same mistake again later. But the only thing I can come up with is lots of work.
Acked-by: Peter Zijlstra <peterz@infradead.org>
| |