Messages in this thread |  | | Date | Mon, 24 Feb 2014 08:57:38 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface |
| |
On Sun, Feb 23, 2014 at 08:23:35PM -0600, minyard@acm.org wrote: > @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val) > INIT_LIST_HEAD(&msgs); > > spin_lock_irqsave(&intf->events_lock, flags); > - user->gets_events = val; > + if (user->gets_events == !!val) > + goto out; > + > + user->gets_events = !!val;
Why not have val declared as bool and let compiler convert as needed?
Thanks.
-- Dmitry
|  |