[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 03/11] sysfs: create bin_attributes under the requested group
On Fri, 2014-14-02 at 22:02:07 UTC, Cody P Schafer wrote:
> bin_attributes created/updated in create_files() (such as those listed
> via (struct device).attribute_groups) were not placed under the
> specified group, and instead appeared in the base kobj directory.
> Fix this by making bin_attributes use creating code similar to normal
> attributes.
> A quick grep shows that no one is using bin_attrs in a named attribute
> group yet, so we can do this without breaking anything in usespace.
> Note that I do not add is_visible() support to
> bin_attributes, though that could be done as well.
> Signed-off-by: Cody P Schafer <>

Greg has already taken this, so we'll consider that as good as an ack from him,
unless he wants to give us one.


 \ /
  Last update: 2014-02-25 05:01    [W:0.197 / U:1.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site