[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ASOC: dapm: add param_fixup callback
On Mon, Feb 24, 2014 at 01:54:18PM +0000, NikeshOswal wrote:
> From: nikesh <>

You need to fix both your git and e-mail setups, you should be using
"Nikesh Oswal" or similar as your real name and more importantly your
mail setup is sending mail as "NikeshOswal" with no even a domain part
which means you can't be replied to. It is very important that you are
able to get review comments at the address you post from.

> dai-link params for codec-codec links were fixed.
> The fixed link between codec and another chip which
> may be another codec, baseband, bluetooth codec etc

Please use the full width for your changelog.

> Change-Id: Iad6ee3951bc4e8b8bc519c62642a2b4bcd949c18

Don't include noise like this in upstream submissions.

> - const struct snd_soc_pcm_stream *params;
> + struct snd_soc_pcm_stream *params;
> + /* optional params re-writing for dai links */
> + int (*params_fixup)(struct snd_soc_dapm_widget *w, int event);

This isn't a great interface, it relies on the driver peering inside the
core data structures and it means that we have to drop the consts from
users. Systems not using this feature ought to be able to declare their
parameters as static const but this breaks that ability. Similarly
users that are fully dynamic need to allocate some static data to work
with this interface.

If you look at the existing interface you'll also see that it takes an
array of parameters rather than just a single parameter. The idea was
to extend the interface to provide a control to userspace allowing
selection of one of the configurations from a list for use with cases
like modems which can switch between 8kHz and 16kHz modes.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-02-25 03:21    [W:0.049 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site