Messages in this thread |  | | Date | Tue, 25 Feb 2014 10:00:48 +0900 | Subject | Re: [PATCH v2] staging: ced401: fix double unlock bug | From | DaeSeok Youn <> |
| |
Ok.
I will make a patch based on linux-next branch and send it again. Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>: > On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: >> >> After spin_lock() is called, all of if-else conditions in this brace >> should reach the end of else and spin_unlock() must be called. >> So It doesn't need to call spin_unlock() without a return statement >> for handling an error. >> >> Also sparse says: >> drivers/staging/ced1401/usb1401.c:1080:28: warning: >> context imbalance in 'Handle1401Esc' - unexpected unlock >> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> > > This patch doesn't apply to my tree, can you please redo it against > linux-next and resend it so that I can apply it? > > thanks, > > greg k-h
|  |