[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] staging: dgap: remove unneeded status variables
On Mon, Feb 24, 2014 at 12:21:51AM +0400, Alexey Khoroshilov wrote:
> dgap_driver_start and dgap_Major_Control_Registered are used
> to keep status of initialization of the driver as a whole and its "Major Control".
> But the code that checks them is executed once on module init/unload.
> That makes no sense in these variables as far as their values are predictable
> at any time.
> Signed-off-by: Alexey Khoroshilov <>
> ---
> drivers/staging/dgap/dgap_driver.c | 105 ++++++++++++++++---------------------
> 1 file changed, 46 insertions(+), 59 deletions(-)

This file is no longer in my tree, as the driver has been merged to one
file. Can you please redo it against my latest staging-next branch of
my staging.git tree and resend the series so that I can apply them?


greg k-h

 \ /
  Last update: 2014-02-25 02:21    [W:0.043 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site