Messages in this thread |  | | Date | Mon, 24 Feb 2014 22:07:11 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 08/10] spi: sh-msiof: Move clock management to (un)prepare_message() |
| |
On Mon, Feb 24, 2014 at 10:48:26AM +0100, Geert Uytterhoeven wrote:
> Perhaps it's because the bitbang core may call the .chipselect() callback > multiple times with is_on == BITBANG_CS_ACTIVE, and obviously the > clock should be enabled/disabled only once? > The current code doesn't seem to do that, but perhaps it was different when > the sh-msiof driver was written?
Possibly, or perhaps someone was being overly cautious.
> As you mention yourself, all of this code existed before. It just got moved, > to make the conversion to the SPI core message handling easier. > If you don't mind, I'd like to defer these, and tackle runtime PM later.
Sure. [unhandled content-type:application/pgp-signature] |  |