[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] staging: rtl8187se: fix issues
On Thu, Feb 20, 2014 at 01:05:31AM -0700, wrote:
> From: Axel Rasmussen <>
> Date: Mon, 17 Feb 2014 23:50:05 -0700
> Subject: [PATCH] staging: rtl8187se: fix issues

Please just use 'git send-email' so I don't have to hand-edit the patch
and strip this out :(

> Reformatted many lines which were too long, replaced various printk
> calls with appropriate netdev_* calls, and fixed some spelling errors.

You did multiple things here to this patch, which should be a big hint
that you need to break it up into smaller pieces, each one doing just
one thing. Please do so, otherwise as it is, this patch is way too big
to review.


greg k-h

 \ /
  Last update: 2014-02-25 01:21    [W:0.038 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site