[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] net: phy: add suspend_halted module param
From: Florian Fainelli <>
Date: Mon, 24 Feb 2014 10:20:10 -0800

> Hi Sebastian,
> 2014-02-23 8:58 GMT-08:00 Sebastian Hesselbarth
> <>:
>> commit 1211ce53077164e0d34641d0ca5fb4d4a7574498
>> ("net: phy: resume/suspend PHYs on attach/detach")
>> introduced a feature to suspend PHYs when entering halted state.
>> Unfortunately, not all bootloaders properly power-up PHYs on reset
>> and fail to access ethernet because the PHY is still powered down.
>> Therefore, we add a boolean module parameter suspend_halted with
>> default value of true. Disabling that parameter prevents PHYs from
>> being suspended when entering halted state.
>> Signed-off-by: Sebastian Hesselbarth <>
>> Reported-by: Andrew Lunn <>
>> ---
>> Andrew, can you please re-test if disabling the feature does work on
>> your board? I tried a bunch of mine, but none failed to power-up the
>> PHY in u-boot.
> Would be good to get Andrew's testing on this just to make sure it
> solves his problem. Otherwise:
> Acked-by: Florian Fainelli <>

I disagree with using a module parameter for this.

Figure out the devices that cannot do this properly, and add
an internal flag that this driver sets.

Module parameters are terrible.

 \ /
  Last update: 2014-02-25 00:41    [W:0.144 / U:13.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site