Messages in this thread |  | | Date | Mon, 24 Feb 2014 17:20:20 -0500 | From | Tom Rini <> | Subject | Re: [PATCH] checkpatch.pl: Add warning for new __packed additions |
| |
On 02/24/2014 05:08 PM, Joe Perches wrote: > On Mon, 2014-02-24 at 17:04 -0500, Tom Rini wrote: >> I've got this modified to a CHK and only for non-file usage. Anything >> else we want to talk about before I repost? > > Probably not, but I'm still not convinced it's useful. > > Have you found a case where it's currently specified > but not useful?
Well, U-Boot and the kernel both share the dubious to incorrect __packed horror of cros_ec things (see include/linux/mfd/cros_ec_commands.h).
If this is really not seen as useful for the kernel, that's fine, I'll drop it. I mainly did this for U-Boot where we do want a bit more loud screaming going on when people add __packed to make sure it's for a good reason. Wanted to be a good neighbor so to speak and see if upstream wants it too.
-- Tom
|  |