[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] staging: ced401: remove redundant spin_unlock
On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <>
> Date: Mon, 24 Feb 2014 09:17:41 +0900
> Subject: [PATCH] staging: ced401: remove redundant spin_unlock

Don't send this header. We get everything from the email header.

> sparse says:
> drivers/staging/ced1401/usb1401.c:1080:28: warning:
> context imbalance in 'Handle1401Esc' - unexpected unlock

Your fix is correct, but the changelog is not good. These messages in
Sparse are wrong over 80% of the time. So when I see one in a commit
message I assume it is wrong. Add some more explanation to say why you
removed the spin_unlock.

Also "redundant" means "unnecessary" but sort of implies that it is
harmless. Say something like: "staging: ced401: fix double unlock bug".

dan carpenter

 \ /
  Last update: 2014-02-24 23:41    [W:0.047 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site