lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH for-next 3/4] epoll: struct epoll support
So I was just looking things over quickly, and something jumped out at
me. In ep_control():

> + } else if (!(*io) && epi) {
> + /* delete this eventpoll entry */
> + if (is_file_epoll(target)) {
> + tep = target->private_data;
> + mutex_lock_nested(&tep->mtx, 1);
> + }
> + if (is_file_epoll(target))
> + mutex_lock_nested(&tep->mtx, 1);

How could that possibly work? I can't imagine tep->mtx is going to
react well to being locked a second time...

jon


\
 
 \ /
  Last update: 2014-02-24 21:21    [W:0.095 / U:1.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site