Messages in this thread |  | | Date | Mon, 24 Feb 2014 20:39:39 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: add suspend_halted module param |
| |
On Mon, Feb 24, 2014 at 11:37:15AM -0800, Florian Fainelli wrote: > 2014-02-24 11:15 GMT-08:00 Andrew Lunn <andrew@lunn.ch>: > > On Sun, Feb 23, 2014 at 05:58:39PM +0100, Sebastian Hesselbarth wrote: > >> commit 1211ce53077164e0d34641d0ca5fb4d4a7574498 > >> ("net: phy: resume/suspend PHYs on attach/detach") > >> introduced a feature to suspend PHYs when entering halted state. > >> > >> Unfortunately, not all bootloaders properly power-up PHYs on reset > >> and fail to access ethernet because the PHY is still powered down. > >> > >> Therefore, we add a boolean module parameter suspend_halted with > >> default value of true. Disabling that parameter prevents PHYs from > >> being suspended when entering halted state. > > > > Hi Sebastian > > > > Am i doing something silly here? > > Could the PHY be already suspended during your initial boot?
No. I tftpboot.
> If that > is the case, the first time we all phy_suspend() the flag is true, we > suspend it, and we never wake it again despite changing > suspend_halted. Does it work better if you specify this module > parameter on the initial kernel boot command-line?
I tried that as well, after i emailed. Makes no difference, no working Ethernet.
Andrew
|  |