Messages in this thread |  | | Date | Mon, 24 Feb 2014 20:38:30 +0100 | From | Vladimir 'φ-coder/phcoder' Serbinenko <> | Subject | Re: [Xen-devel] [PATCH] xen: remove XEN_PRIVILEGED_GUEST |
| |
On 24.02.2014 19:39, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 18, 2014 at 11:14:27AM +0100, Paul Bolle wrote: >> On Mon, 2014-02-17 at 09:43 -0500, Konrad Rzeszutek Wilk wrote: >>> On Mon, Feb 17, 2014 at 02:03:17PM +0100, Paul Bolle wrote: >>>> On Mon, 2014-02-17 at 07:23 -0500, Konrad Rzeszutek Wilk wrote: >>>>> On Feb 16, 2014 3:07 PM, Paul Bolle <pebolle@tiscali.nl> wrote: >>>>> Please look in the grub git tree. They have fixed their code to not do >>>>> this anymore. This should be reflected in the patch description. >>>> >>>> Thanks, I didn't know that. That turned out to be grub commit >>>> ec824e0f2a399ce2ab3a2e3353d372a236595059 ("Implement grub_file tool and >>>> use it to implement generating of config"), see >>>> http://git.savannah.gnu.org/cgit/grub.git/commit/util/grub.d/20_linux_xen.in?id=ec824e0f2a399ce2ab3a2e3353d372a236595059 >> >> And that commit was reverted a week later in grub commit >> faf4a65e1e1ce1d822d251c1e4b53d96ec7faec5 ("Revert grub-file usage in >> grub-mkconfig."), see >> http://git.savannah.gnu.org/cgit/grub.git/commit/util/grub.d/20_linux_xen.in?id=faf4a65e1e1ce1d822d251c1e4b53d96ec7faec5 . >> >> That commit has no explanation (other than its one line summary). So >> we're left guessing why this was done. Luckily, it doesn't matter here, >> because the test for CONFIG_XEN_PRIVILEGED_GUEST is superfluous. > > How about we ask Vladimir? > > Vladimir - could you shed some light on it? Thanks! > CONFIG_XEN_PRIVILEGED_GUEST is not present on Linux even though it should be. The test was removed to accomodate this. The usage of grub-file was removed because it wasn't release-ready. >> >> Anyhow, I hope to submit a second version of this patch later this day. >> >> >> Paul Bolle >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel >
[unhandled content-type:application/pgp-signature] |  |