lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH for-next 3/4] epoll: struct epoll support
From
On 2/24/14, Jonathan Corbet <corbet@lwn.net> wrote:
> So I was just looking things over quickly, and something jumped out at
> me. In ep_control():
>
>> + } else if (!(*io) && epi) {
>> + /* delete this eventpoll entry */
>> + if (is_file_epoll(target)) {
>> + tep = target->private_data;
>> + mutex_lock_nested(&tep->mtx, 1);
>> + }
>> + if (is_file_epoll(target))
>> + mutex_lock_nested(&tep->mtx, 1);
>
> How could that possibly work? I can't imagine tep->mtx is going to
> react well to being locked a second time...

Wow...I have no idea how I missed that, must've been moving stuff
around and accidentally duplicated that somehow. Thanks for setting
me straight, this is why I like to start with an RFC :)

Appreciate the input,
Nate


\
 
 \ /
  Last update: 2014-02-24 21:02    [W:0.030 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site