Messages in this thread |  | | Date | Mon, 24 Feb 2014 11:24:28 -0800 | Subject | Re: [RFC PATCH for-next 3/4] epoll: struct epoll support | From | Nathaniel Yazdani <> |
| |
On 2/24/14, Jonathan Corbet <corbet@lwn.net> wrote: > So I was just looking things over quickly, and something jumped out at > me. In ep_control(): > >> + } else if (!(*io) && epi) { >> + /* delete this eventpoll entry */ >> + if (is_file_epoll(target)) { >> + tep = target->private_data; >> + mutex_lock_nested(&tep->mtx, 1); >> + } >> + if (is_file_epoll(target)) >> + mutex_lock_nested(&tep->mtx, 1); > > How could that possibly work? I can't imagine tep->mtx is going to > react well to being locked a second time...
Wow...I have no idea how I missed that, must've been moving stuff around and accidentally duplicated that somehow. Thanks for setting me straight, this is why I like to start with an RFC :)
Appreciate the input, Nate
|  |