Messages in this thread | | | Date | Mon, 24 Feb 2014 17:23:13 +1100 | From | Stephen Rothwell <> | Subject | Re: linux-next: build warning after merge of the tip tree |
| |
Hi Andrew,
On Sun, 23 Feb 2014 22:12:17 -0800 Andrew Morton <akpm@linux-foundation.org> wrote: > > Doh, I missed that. I don't know if it's "allowed" or not, but it's > clearly the wrong thing to do - the whole point of asmlinkage is to > export the thing to other compilation units. > > So I suppose this: > > mm/process_vm_access.c:416:1: warning: no previous prototype for `compat_process_vm_rw' [-Wmissing-prototypes] > > should be squashed by giving it a prototype. Something like
Or maybe it should be static but *not* asmlinkage like process_vm_rw() ?
As far as I can see it is only used in mm/process_vm_access.c. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au [unhandled content-type:application/pgp-signature] | |