lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ASoC: cs42888: Add codec driver support
Date

>
>> + /* Disable auto-mute */
>> + regmap_update_bits(cs42888->regmap, CS42888_TXCTL,
>> + CS42888_TXCTL_AMUTE | CS42888_TXCTL_DAC_SZC_MASK,
>> + CS42888_TXCTL_DAC_SZC_SR);
>
> Does this interfere with the manual mute controls or is it a separate
> thing? If it plays nicely with the manual controls it's probably better
> to leave it enabled since it improves performance in some benchmarks
> (that's why hardware tends to have the feature).

Auto-Mute should be enabled by default.

>
>> + if (!IS_ERR(cs42888->clk))
>> + clk_disable_unprepare(cs42888->clk);
>
> Does the device work without MCLK?
Yes, MCLK is required. If you can’t get the clock you should error out.


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-24 18:01    [W:0.836 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site