Messages in this thread | | | Date | Mon, 24 Feb 2014 13:19:02 +0000 | From | One Thousand Gnomes <> | Subject | Re: [PATCH RESEND] x86: iosf_mbi: Provide dummy functions if CONFIG_IOSF_MBI not set |
| |
On Sat, 22 Feb 2014 17:02:32 -0800 "David E. Box" <david.e.box@linux.intel.com> wrote:
> From: "David E. Box" <david.e.box@linux.intel.com> > > Add iosf_mbi_available function for loadable modules. > Add dummy functions to prevent symbol lookup errors on loadable modules. > Clarify that the write opcode is to be used for iosf_mbi_modify(). > Changes Kconfig for IOSF_MBI to default built-in.
Other than _available I would have expected all the others to resolve to returning an error or doing a WARN() in the not compiled in case.
If someone is dumb enough to miss the checks we want the kernel to spew forth copious announcements of the fact, not silently do nothing.
Alan
| |