[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration
On Sun, Feb 23, 2014 at 9:32 PM, Eric Wong <> wrote:
> Nathaniel Yazdani <> wrote:
>> +asmlinkage long sys_epoll(int ep, struct epoll __user *in,
>> + unsigned int inc, struct epoll __user *out,
>> + unsigned int outc, int timeout);
> I can understand using the new struct for 'in', but 'out' could just be
> "struct epoll_event *" like sys_epoll_wait, right?
>> asmlinkage long sys_epoll_wait(int epfd, struct epoll_event __user *events,

Yeah and I went back and forth on that, it just seemed to me that the
inconsistency could be confusing to others... maybe instead of defining a new
struct to begin with it might make me sense to just have an 'infd' array of file
descriptors in addition to an 'in' array of epoll_event struct
(obviously the length
of these would be identical).

 \ /
  Last update: 2014-02-24 07:21    [W:0.072 / U:2.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site