[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v11] gpio: add a driver for the Synopsys DesignWare APB GPIO block
On Wed, Feb 12, 2014 at 5:17 PM, delicious quinoa
<> wrote:

> I am wondering about the change in usage of
> irq_find_mapping/irq_create_mapping. It seems like all the GPIO
> drivers that use irq domains do it the way I was doing it

It is a well known problems that the kernel contain many bad
examples. When in doubt ask for a good example to be provided.

In gpio-omap.c you will find that this is done in the probe()

> (that's
> where I got the idea in the first place): irq_create_mapping is used
> in the to_irq() function. I guess this is a general direction all the
> other drivers will be encouraged to go in also?

Yes. The reason is that it should be possible to reques an IRQ
from an irqchip no matter whether the gpio_to_irq() function
was called first, as the APIs are orthogonal.

Linus Walleij

 \ /
  Last update: 2014-02-24 14:01    [W:0.062 / U:1.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site