Messages in this thread |  | | Date | Mon, 24 Feb 2014 13:08:46 +0100 | Subject | Re: [PATCH] of/gpio: Define OF_GPIO_OPEN_DRAIN flag for Open Drain outputs. | From | Linus Walleij <> |
| |
On Mon, Feb 10, 2014 at 11:05 PM, David Daney <ddaney.cavm@gmail.com> wrote:
> From: David Daney <david.daney@cavium.com> > > When we have a GPIO pin connected to an open-drain network, we want a > standard way of specifying this in the device tree. So we choose bit > 1 of the flag field to indicate open drain.
This is a good idea.
But the patch is missing two things:
- Add open source as well, as indicated.
- Add this definition to include/dt-bindings/gpio/gpio.h
- Add this *and* the missing active low property to the binding documentation in: Documentation/devicetree/bindings/gpio/gpio.txt (pls help with this!)
Yours, Linus Walleij
|  |