lkml.org 
[lkml]   [2014]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] of/gpio: Define OF_GPIO_OPEN_DRAIN flag for Open Drain outputs.
From
On Mon, Feb 10, 2014 at 11:05 PM, David Daney <ddaney.cavm@gmail.com> wrote:

> From: David Daney <david.daney@cavium.com>
>
> When we have a GPIO pin connected to an open-drain network, we want a
> standard way of specifying this in the device tree. So we choose bit
> 1 of the flag field to indicate open drain.

This is a good idea.

But the patch is missing two things:

- Add open source as well, as indicated.

- Add this definition to include/dt-bindings/gpio/gpio.h

- Add this *and* the missing active low property to the binding
documentation in:
Documentation/devicetree/bindings/gpio/gpio.txt
(pls help with this!)

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-02-24 13:41    [W:0.492 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site