Messages in this thread | | | Date | Sun, 23 Feb 2014 09:56:56 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH v2 2/2] x86: Support compiling out human-friendly processor feature names |
| |
On 02/22/2014 01:36 PM, Josh Triplett wrote: > > No, even after removing the ifdefs around the build rules as you > suggested (and v3's fixes for the resulting build issues, notably > changing some -y's to -$(CONFIG_X86_FEATURE_NAMES)), the makefiles still > manage to not build mkcpustr or cpustr.h, because nothing depends on it. >
How could it miss the rule:
$(obj)/cpu.o: $(obj)/cpustr.h
> I could change the build rules to generate an empty cpustr.h and avoid > this ifdef, but that'd require an additional ifdef block in the Makefile.
Typically the way it is done is to generate the #ifdef *inside* cpustr.h. However, cpustr.h is kind of special anyway so it probably doesn't matter.
-hpa
| |